On Wed, 19 Feb 2020 21:19:02 +0000 lxsameer@xxxxxxx wrote: > From: Sameer Rahmani <lxsameer@xxxxxxx> > > Reviewed and converted the `kobject.txt` format to rst in place. > > Signed-off-by: Sameer Rahmani <lxsameer@xxxxxxx> > --- > Documentation/kobject.txt | 80 +++++++++++++++++++-------------------- > 1 file changed, 40 insertions(+), 40 deletions(-) So I think this is generally OK, if just a bit heavy-handed with the markup. One thing right at the beginning catches my eye, though: > diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt > index ff4c25098119..7c22cdfffd6d 100644 > --- a/Documentation/kobject.txt > +++ b/Documentation/kobject.txt > @@ -3,7 +3,7 @@ Everything you never wanted to know about kobjects, ksets, and ktypes > ===================================================================== > > :Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > -:Last updated: December 19, 2007 > +:Last updated: Feb 18, 2020 This change suggests that the document is current as of last week. Unless you've made sure that it actually matches the current state of the kobject code in the v5.6-rc kernels, it's probably better to leave that date untouched as a warning to others. Things are relatively static in kobject land, but I still suspect there might just be a change or two over the last twelve years...? Thanks, jon
