Re: [PATCH v3 1/3] lib/vsprintf: add two device node flags for %pOF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 20, 2020 at 10:36:52PM +0900, Sergey Senozhatsky wrote:
> On (20/01/20 19:38), lijiazi wrote:
> >  Documentation/core-api/printk-formats.rst | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst
> > index 8ebe46b1..9271f20 100644
> > --- a/Documentation/core-api/printk-formats.rst
> > +++ b/Documentation/core-api/printk-formats.rst
> > @@ -441,6 +441,8 @@ Examples::
> >  							d - detached
> >  							P - Populated
> >  							B - Populated bus
> > +							O - Overlay
> > +							F - Overlay free cset
> 
> I think these 3 can be just one patch. Patching Documentation and
> vsprintf in separate steps might be a bit inconvenient.

The new flags addition may be a subject to discuss. That's why I suggested
to split it out. Though the above misses the functionality for these flags.

Adding a flag counter to the OF header is orthogonal to printf() changes,
it may be there independently. So, it should be a separate patch.

The comment added there is doubtful, though.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux