Ignore this, I posted it just now... On Sun, Dec 29, 2019 at 6:43 PM Yangtao Li <tiny.windzz@xxxxxxxxx> wrote: > > platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for > requesting IRQ's resources, as they can be not ready yet. Using > platform_get_irq() instead is preferred for getting IRQ even if it > was not retrieved earlier. > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> > --- > drivers/platform/goldfish/goldfish_pipe.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index cef0133aa47a..a1ebaec6eea9 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev) > return -EINVAL; > } > > - r = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!r) > - return -EINVAL; > - > - dev->irq = r->start; > + dev->irq = platform_get_irq(pdev, 0); > + if (dev->irq < 0) > + return dev->irq; > > /* > * Exchange the versions with the host device > -- > 2.17.1 >
