On Fri, 20 Dec 2019 06:01:21 +0100 SeongJae Park <sj38.park@xxxxxxxxx> wrote: > On Thu, 19 Dec 2019 16:37:28 -0700 shuah <shuah@xxxxxxxxxx> wrote: > > > On 12/11/19 7:27 PM, SeongJae Park wrote: > > > This patchset contains trivial fixes for the kunit documentations and > > > the wrapper python scripts. > > > > > > > > > Baseline > > > -------- > > > > > > This patchset is based on 'kselftest/fixes' branch of > > > linux-kselftest[1]. A complete tree is available at my repo: > > > https://github.com/sjp38/linux/tree/kunit_fix/20191205_v6 > > > > > > > > > Version History > > > --------------- > > > > > > Changes from v5 > > > (https://lore.kernel.org/linux-kselftest/20191205093440.21824-1-sjpark@xxxxxxxxxx): > > > - Rebased on kselftest/fixes > > > - Add 'Reviewed-by' and 'Tested-by' from Brendan Higgins > > > > > > Changes from v4 > > > (https://lore.kernel.org/linux-doc/1575490683-13015-1-git-send-email-sj38.park@xxxxxxxxx/): > > > - Rebased on Heidi Fahim's patch[2] > > > - Fix failing kunit_tool_test test > > > - Add 'build_dir' option test in 'kunit_tool_test.py' > > > > > > Changes from v3 > > > (https://lore.kernel.org/linux-kselftest/20191204192141.GA247851@xxxxxxxxxx): > > > - Fix the 4th patch, "kunit: Place 'test.log' under the 'build_dir'" to > > > set default value of 'build_dir' as '' instead of NULL so that kunit > > > can run even though '--build_dir' option is not given. > > > > > > Changes from v2 > > > (https://lore.kernel.org/linux-kselftest/1575361141-6806-1-git-send-email-sj38.park@xxxxxxxxx): > > > - Make 'build_dir' if not exists (missed from v3 by mistake) > > > > > > Changes from v1 > > > (https://lore.kernel.org/linux-doc/1575242724-4937-1-git-send-email-sj38.park@xxxxxxxxx): > > > - Remove "docs/kunit/start: Skip wrapper run command" (A similar > > > approach is ongoing) > > > - Make 'build_dir' if not exists > > > > > > SeongJae Park (6): > > > docs/kunit/start: Use in-tree 'kunit_defconfig' > > > kunit: Remove duplicated defconfig creation > > > kunit: Create default config in '--build_dir' > > > kunit: Place 'test.log' under the 'build_dir' > > > kunit: Rename 'kunitconfig' to '.kunitconfig' > > > kunit/kunit_tool_test: Test '--build_dir' option run > > > > > > Documentation/dev-tools/kunit/start.rst | 13 +++++-------- > > > tools/testing/kunit/kunit.py | 18 +++++++++++------- > > > tools/testing/kunit/kunit_kernel.py | 10 +++++----- > > > tools/testing/kunit/kunit_tool_test.py | 10 +++++++++- > > > 4 files changed, 30 insertions(+), 21 deletions(-) > > > > > > > Hi SeongJae Park, > > > > Please make sure your From and Signed-off-by addresses match. I tried > > applying these patches and I am seeing warnings. > > > > WARNING: Missing Signed-off-by: line by nominal patch author 'SeongJae > > Park <sj38.park@xxxxxxxxx>' > > I tried to reproduce the warning on my side using 'git am' and 'checkpatch.pl', > but those doesn't show me such warnings. Could you please let me know what > command you use? Or, you could simply ignore the warning and use 'SeongJae > Park <sjpark@xxxxxxxxx>'. Seems like 'send-email' has ignored 'From:' in my original patche files. I rebased those on latest kselftest/fixes and sent v7. If anything wrong, please let me know. Thanks, SeongJae Park > > > Thanks, > SeongJae Park > > > > > thanks, > > -- Shuah >
