Hi Randy, Thank you for your review! On Sun, 8 Dec 2019 11:34:32 -0800 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > Hi, > > On 12/2/19 2:13 AM, Masami Hiramatsu wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 67a602ee17f1..13bb3eac804c 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -1235,6 +1235,17 @@ source "usr/Kconfig" > > > > endif > > > > +config BOOT_CONFIG > > + bool "Boot config support" > > + select LIBXBC > > + default y > > questionable "default y". > That needs lots of justification. OK, I can make it 'n' by default. I thought that was OK because most of the memories for the bootconfig support were released after initialization. If user doesn't pass the bootconfig, only the code for /proc/bootconfig remains on runtime memory. > > + help > > + Extra boot config allows system admin to pass a config file as > > + complemental extension of kernel cmdline when boot. > > when booting. OK. > > > + The boot config file is usually attached at the end of initramfs. > > The 3 help text lines above should be indented with one tab + 2 spaces, > like the "If" line below. Ah, thanks for pointing it out! I'll fix that. Thank you, > > > + > > + If unsure, say Y. > > + > > choice > > prompt "Compiler optimization level" > > default CC_OPTIMIZE_FOR_PERFORMANCE > > > -- > ~Randy > -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
