On Sun, Dec 1, 2019 at 3:25 PM SeongJae Park <sj38.park@xxxxxxxxx> wrote: > > From: SeongJae Park <sjpark@xxxxxxxxx> > > If both '--build_dir' and '--defconfig' are given, the handling of > '--defconfig' ignores '--build_dir' option. This commit modifies the > behavior to respect '--build_dir' option. > > Signed-off-by: SeongJae Park <sjpark@xxxxxxxxx> > --- > tools/testing/kunit/kunit.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py > index f8f2695..1746330 100755 > --- a/tools/testing/kunit/kunit.py > +++ b/tools/testing/kunit/kunit.py > @@ -114,6 +114,11 @@ def main(argv, linux=None): > cli_args = parser.parse_args(argv) > > if cli_args.subcommand == 'run': > + if cli_args.build_dir: > + kunit_kernel.KUNITCONFIG_PATH = os.path.join( If you are going to modify the value of KUNITCONFIG_PATH can you rename the variable to make it lower_snake_case? UPPER_SNAKE_CASE in Python is usually (at least in this directory) used to indicate the variable is a constant. > + cli_args.build_dir, > + kunit_kernel.KUNITCONFIG_PATH) > + > if cli_args.defconfig: > create_default_kunitconfig() > > -- > 2.7.4 >
