On Sat, 23 Nov 2019 10:50:21 -0800, Jakub Kicinski wrote: > On Fri, 22 Nov 2019 12:37:08 +0000, Russell King wrote: > > There are no users of phy_ethtool_sset() in the kernel anymore, and > > as of 3c1bcc8614db ("net: ethernet: Convert phydev advertize and > > supported from u32 to link mode"), the implementation is slightly > > buggy - it doesn't correctly check the masked advertising mask as it > > used to. > > > > Remove it, and update the phy documentation to refer to its replacement > > function. > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > Applied, thank you! FWIW I've added the word "commit" before the hash, checkpatch is really insistent on that.