Re: [PATCH v6 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/19/19 8:10 AM, Jens Axboe wrote:
> On 11/19/19 1:16 AM, John Hubbard wrote:
>> Convert fs/io_uring to use the new pin_user_pages() call, which sets
>> FOLL_PIN. Setting FOLL_PIN is now required for code that requires
>> tracking of pinned pages, and therefore for any code that calls
>> put_user_page().
>>
>> In partial anticipation of this work, the io_uring code was already
>> calling put_user_page() instead of put_page(). Therefore, in order to
>> convert from the get_user_pages()/put_page() model, to the
>> pin_user_pages()/put_user_page() model, the only change required
>> here is to change get_user_pages() to pin_user_pages().
>>
>> Reviewed-by: Jan Kara <jack@xxxxxxx>
>> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> 
> You dropped my reviewed-by now... Given the file, you'd probably want
> to keep that.

Hi Jens,

Yes, I was being too conservative I guess. I changed the patch somewhat
and dropped the reviewed-by because of those changes...I'm adding it
back for v7 based on this, thanks!

thanks,
-- 
John Hubbard
NVIDIA
 



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux