On Mon, Oct 21, 2019 at 01:38:32PM +1300, Chris Packham wrote: > "on the safe size" should be "on the safe side". > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> Yes, it should. Acked-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> If you like, you could do a follow-up patch mentioning the use of struct_size(), array_size() and array3_size(). I think this document is the right place for those. Their kernel-doc is included in driver-api/basics.rst, but referencing those functions in this document would draw peoples' attention to them.