On Wed, Oct 16, 2019 at 5:52 PM Petr Mladek <pmladek@xxxxxxxx> wrote: > > On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote: > > On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes > > <linux@xxxxxxxxxxxxxxxxxx> wrote: > > > > > +const char *errname(int err) > > > +{ > > > + const char *name = __errname(err > 0 ? err : -err); > > > > Looks like mine comment left unseen. > > What about to simple use abs(err) here? > > Andy, would you want to ack the patch with this change? > I could do it when pushing the patch. Looks good to me. Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Otherwise, it looks ready to go. > > Thanks everybody involved for the patience. -- With Best Regards, Andy Shevchenko