Hello Greg, Am 11.10.2019 um 08:43 schrieb Greg Kroah-Hartman:
On Sun, Sep 22, 2019 at 08:03:56AM +0200, Heiko Schocher wrote:+struct __attribute__ ((packed)) msg_queue_user { + int type; /* CC1101_MSG_SET_ */ +}; + +/* CC1101_MSG_DEFINE_CONFIG */ +struct __attribute__ ((packed)) config_param { + char addr; + char val; +};{sigh}
Sorry for that ...
None of these structures are valid ones to be passing to/from userspace/kernel at all. Please fix them up to work properly (i.e. use the correct types and such). I think there's a "how to write a correct ioctl" document in the documentation directory somewhere, you might want to search for that.
Ok, the driver does not use ioctl only read/write, but the overall question is, has this driver at all a chance to go into mainline? I searched for "write a correct" in Documentation but get: $ grep -lr "write a correct" Documentation/ $ May "Documentation/ioctl/botching-up-ioctls.rst" helps, so I convert to use the __u* types, thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@xxxxxxx
