On Thu, 2019-10-10 at 08:21 -0700, Guenter Roeck wrote: > [External] > > On Thu, Oct 10, 2019 at 07:13:06AM +0000, Sa, Nuno wrote: > > Quoting the reply I had: > > > > "As the LTC2947 is bi-directional, the most likely use for the > > Min/Max > > Energy thresholds are for monitoring a battery being charged or > > discharged. > > A limit could be set based around the battery's storage capacity so > > that the battery is protected from being overcharging or fully > > drained." > > > > So, I'm not sure if this is a valid use case for hwmon subsystem. > > I'm > > aware there's also the power subsystem. So let me know what do you > > prefer here. Should I just report energyX_input attributes? Or can > > we > > keep the min/max? > > > This isn't really a hwmon use case. Having such min/max attributes > would > just be confusing. > Got it. Then I will remove min/max and the alarm attributes for energy and just leave the standard ones. When I have the time I might prepare a patch which turns this device into an mfd and adds a new driver in the power subsystem to monitor charge and energy so that it can cover this use case. I guess that would make sense. Nuno Sá
