Hi André, Jens, On Wed, 2019-09-11 at 11:46 -0300, André Almeida wrote: > The name of the module is "null_blk", not "null". Make `pr_info()` follow > the pattern of `pr_err()` log messages. > Instead of doing these fixes manually, it's more consistent and smarter to use pr_fmt. There are many examples of drivers doing that. I don't know if this patch can be dropped, and replaced with one used pr_fmt or if doesn't worth the trouble. It would be even better to also patch Documentation/process/coding-style.rst, in particular the printing section, making a mention to pr_fmt. Thanks, Ezequiel