Hi Daniel, On 04/09/2019 21:42, Daniel Jordan wrote: >> In addition, the tables that are printed by the script were not properly >> aligned any more, so patch 2 fixes the spacing. > > Nit, not for Pages Scanned. With your series I get > > Kswapd Kswapd Order Pages Pages Pages Pages > Instance Wakeups Re-wakeup Scanned Rclmed Sync-IO ASync-IO > kswapd0-175 1 0 253694 253691 3 129896 wake-0=1 Whoops, you're right, I'll fix that in v2. > I wonder if we shouldn't just get rid of the whole script, it's hard to > remember to keep in sync with vmscan changes and I can't think of a way to > remedy that short of having mm regression tests that run this. But your > patches are an improvement for now. That's definitely one possibility. If history has shown that these break and aren't properly kept in line, they could go. Alternatively, as Yafang suggested, integrating them into the perf test suite might help with the issues. I'll ignore that point for now though and just send a v2 for this patch series. Thanks for the feedback, Florian
