Re: [PATCH 1/5] drm/ttm: add drm_gem_ttm_print_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Hi,

> > +		[ TTM_PL_SYSTEM ] = "system",
> > +		[ TTM_PL_TT     ] = "tt",
> > +		[ TTM_PL_VRAM   ] = "vram",
> > +		[ TTM_PL_PRIV   ] = "priv",
> > +
> 
> This 'gap' in the array seems to be a problem for drivers that use these
> bits. Could the print logic be moved into s separate function that also
> takes the array as an argument?

Are there any drivers which actually use these bits and which therefore
might want to use a different array?

Also note they should not cause any problems (other than not being
printed).  There is an explicit check here ...

> > +		if (!plname[i])
> > +			continue;

.. to skip unknown bits.

cheers,
  Gerd




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux