On 2019-08-27 13:35, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin <peda@xxxxxxxxxx> wrote: >> The variable is only ever used from fbcon.c which is linked into the >> same module. Therefore, the export is not needed. >> >> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > But note that the same is true for fb_class, so perhaps it can be added > (or better, removed ;-)? Right. Someone please let me know if 3/3 needs to be extended. I'm also happy to just drop it... > Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[] > and num_registered_fb, those can go, too. > > Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo() > itself? Maybe there should be a small drivers/video/fbdev/core/fbmem.h file (or something) with these "internal" declarations, to hide some clutter currently in include/linux/fb.h? Feels like that could be done later, after these other cleanups you mention, so that the new file has a few more things to declare. Cheers, Peter
