Hari Bathini <hbathini@xxxxxxxxxxxxx> writes: > On 26/08/19 4:14 PM, Sourabh Jain wrote: >> On 8/26/19 3:46 PM, Sourabh Jain wrote: >>> On 8/26/19 3:29 PM, Hari Bathini wrote: >>>> On 10/08/19 11:29 PM, Sourabh Jain wrote: >>>>> Add a sys interface to allow querying the memory reserved by >>>>> fadump for saving the crash dump. >>>>> >>>>> Add an ABI doc entry for new sysfs interface. >>>>> - /sys/kernel/fadump_mem_reserved >>>>> >>>>> Signed-off-by: Sourabh Jain <sourabhjain@xxxxxxxxxxxxx> >>>>> --- >>>>> Changelog: >>>>> v1 -> v2: >>>>> - Added ABI doc for new sysfs interface. >>>>> >>>>> v2 -> v3: >>>>> - Updated the ABI documentation. >>>>> --- >>>>> >>>>> Documentation/ABI/testing/sysfs-kernel-fadump | 6 ++++++ >>>> >>>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved? >> >> How about documenting fadump_mem_reserved and other sysfs attributes suggested >> by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump? > > I wouldn't mind that but please do check if it is breaking a convention.. AIUI a file named like that would hold the documentation for the files inside a directory called /sys/kernel/fadump. And in fact that's probably where these files should live, rather than just dropped directly into /sys/kernel. cheers
