On Fri, 23 Aug 2019 10:39:50 +0000, Vlad Buslov wrote: > >> +/* Destroy filter and decrement block offload counter, if filter was previously > >> + * offloaded. > >> + */ > >> + > > > > hm.. is this gap between comment and function it pertains to > > intentional? > > Majority of function comments in cls_api.c have newline after them (not > all of them though). I don't have any strong opinions regarding this. > You suggest it is better not to have blank lines after function > comments? Ah, you're right. I think it's pretty strange to have a new line after a comment which pertains only to the function which is immediately following it. Often the new line is used as a separation, when the comment describes whole section of the file.. I kind of wish kdoc allowed none of the parameters to be described. Often you want to document the function but the parameters are kind of obvious. Anyway... feel free to leave this as is.
