On Mon, 19 Aug 2019 17:04:53 -0700 Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: > On Mon, 19 Aug 2019 18:31:34 +0200, Thomas Bogendoerfer wrote: > > netif_stop_queue()/netif_wake_qeue() aren't needed for changing > > multicast filters. Use spinlocks instead for proper protection > > of private struct. > > > > I thought it may protect ip->emcr, but that one is accessed with no > locking from the ioc3_timer() -> ioc3_setup_duplex() path.. it should protect ip->emcr ... I'll add spin_lock/unlock to setup_duplex and respin the patch. Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
