On Tue, 20 Aug 2019 08:23:08 +0200 Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote: > On 19/08/2019 18:31:38+0200, Thomas Bogendoerfer wrote: > > diff --git a/drivers/mfd/ioc3.c b/drivers/mfd/ioc3.c > > new file mode 100644 > > index 000000000000..5bcb3461a189 > > --- /dev/null > > +++ b/drivers/mfd/ioc3.c > > @@ -0,0 +1,586 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * SGI IOC3 multifunction device driver > > + * > > + * Copyright (C) 2018, 2019 Thomas Bogendoerfer <tbogendoerfer@xxxxxxx> > > + * > > + * Based on work by: > > + * Stanislaw Skowronek <skylark@xxxxxxxxxxxxx> > > + * Joshua Kinard <kumba@xxxxxxxxxx> > > + * Brent Casavant <bcasavan@xxxxxxx> - IOC4 master driver > > + * Pat Gefre <pfg@xxxxxxx> - IOC3 serial port IRQ demuxer > > + */ > > + > > +#include <linux/delay.h> > > +#include <linux/errno.h> > > +#include <linux/interrupt.h> > > +#include <linux/mfd/core.h> > > +#include <linux/module.h> > > +#include <linux/pci.h> > > +#include <linux/platform_device.h> > > +#include <linux/platform_data/sgi-w1.h> > > +#include <linux/rtc/ds1685.h> > I don't think this include is necessary. you are right. I'll move it to the patch where IP30 systemboard gets added. Thanks, Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
