Re: [PATCH v1] kernel-doc: Allow anonymous enum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 13, 2019 at 03:19:12PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 12, 2019 at 03:13:17PM -0600, Jonathan Corbet wrote:
> > On Mon, 12 Aug 2019 19:06:31 +0300
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > 
> > > In C is a valid construction to have an anonymous enumerator.
> > > 
> > > Though we have now:
> > > 
> > >   drivers/pinctrl/intel/pinctrl-intel.c:240: error: Cannot parse enum!
> > > 
> > > Support it in the kernel-doc script.
> > 
> > So I don't get this error; I guess the only anonymous enum of interest has
> > yet to find its way into the mainline.
> 
> The other one is already in mainline (drivers/remoteproc/omap_remoteproc.h),
> but suddenly it misses the second * in the header of kernel-doc comment
> (perhaps to avoid above error, or for another reason).

Actually more without full description

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:186:

Or with format which messes name with description

drivers/misc/mic/cosm/cosm_main.h:19:
include/linux/amba/pl022.h:166:

Or above variants together

drivers/pinctrl/pinctrl-rockchip.c:86:
drivers/pinctrl/pinctrl-rockchip.c:98:


Noticed also broken references like

drivers/scsi/isci/port.c:1193:
drivers/usb/host/ehci-timer.c:381:

where enum mentioned without leading &.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux