On Mon, Aug 05, 2019 at 05:52:40PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > > As these two functions are used by other private features. e.g. > > in error reporting private feature, it requires to check port status > > and reset port for error clearing. > > > > Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx> > > Signed-off-by: Wu Hao <hao.wu@xxxxxxxxx> > > Acked-by: Moritz Fischer <mdf@xxxxxxxxxx> > > Acked-by: Alan Tull <atull@xxxxxxxxxx> > > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx> > > --- > > v2: rebased > > --- > > drivers/fpga/dfl-afu-main.c | 25 ++++++++++++++----------- > > drivers/fpga/dfl-afu.h | 3 +++ > > 2 files changed, 17 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c > > index e013afb..e312179 100644 > > --- a/drivers/fpga/dfl-afu-main.c > > +++ b/drivers/fpga/dfl-afu-main.c > > @@ -22,14 +22,16 @@ > > #include "dfl-afu.h" > > > > /** > > - * port_enable - enable a port > > + * __port_enable - enable a port > > * @pdev: port platform device. > > * > > * Enable Port by clear the port soft reset bit, which is set by default. > > * The AFU is unable to respond to any MMIO access while in reset. > > - * port_enable function should only be used after port_disable function. > > + * __port_enable function should only be used after __port_disable function. > > + * > > + * The caller needs to hold lock for protection. > > */ > > -static void port_enable(struct platform_device *pdev) > > +void __port_enable(struct platform_device *pdev) > > worst global function name ever. > > Don't polute the global namespace like this for a single driver. If you > REALLY need it, then use a prefix that shows it is your individual > dfl_special_sauce_platform_device_only type thing. Oh.. Sure.. Let me fix the naming in the next version. Thanks Hao > > thanks, > > greg k-h
