On Tue, 2019-07-09 at 11:10 +0530, NitinGote wrote:
> From: Nitin Gote <nitin.r.gote@xxxxxxxxx>
>
> 1. Deprecate strcpy() in favor of strscpy().
> 2. Deprecate strlcpy() in favor of strscpy().
> 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad().
>
> Updated strncpy() section in Documentation/process/deprecated.rst
> to cover strscpy_pad() case.
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Kees, I think the concept is fine, but perhaps your
acked-by here isn't great. There are a few clear
defects in the checkpatch code that you also might
have overlooked.
> Change log:
> v1->v2
> - For string related apis, created different %deprecated_string_api
> and these will get emitted at CHECK Level using command line option
> -f/--file to avoid bad patched from novice script users.
>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -605,6 +605,21 @@ foreach my $entry (keys %deprecated_apis) {
> }
> $deprecated_apis_search = "(?:${deprecated_apis_search})";
>
> +our %deprecated_string_apis = (
> + "strcpy" => "strscpy",
> + "strlcpy" => "strscpy",
> + "strncpy" => "strscpy, strscpy_pad or for non-NUL-terminated strings,
> + strncpy() can still be used, but destinations should be marked with the __nonstring",
This last strncpy line should not be on multiple lines.
checkpatch output is single line.
[]
> @@ -6446,6 +6461,16 @@ sub process {
> "Deprecated use of '$deprecated_api', prefer '$new_api' instead\n" . $herecurr);
> }
>
> +# check for string deprecated apis
> + if ($line =~ /\b($deprecated_string_apis_search)\b\s*\(/) {
> + my $deprecated_string_api = $1;
> + my $new_api = $deprecated_string_apis{$deprecated_string_api};
> + $check = 1;
> + CHK("DEPRECATED_API",
> + "Deprecated use of '$deprecated_string_api', prefer '$new_api' instead\n" . $herecurr);
> + $check = 0;
nack.
Please use consistent tab indentation and no,
do not set and unset $check.
Please use the same style as the rest of the script
when emitting at different levels for -f uses
my $msg_level = \&WARN;
$msg_level = \&CHK if ($file);
&{$msg_level}("DEPRECATED_API", etc...
