On Thu, Jul 04, 2019 at 04:58:55PM +0800, Wu Hao wrote: > > > Hope things could be more clear now. :) > > > > That's nice for the vfio stuff, but you are just a "normal" driver here. > > You want an ioctl that just does one thing, no arguments, no flags, no > > anything. No need for a size argument then at all. These ioctls don't > > even need a structure for them! > > > > Don't try to be fancy, it's not needed, it's not like you are running > > out of ioctl space... > > Thanks a lot for the comments and suggestions. > > That's true, it's a "normal" driver, maybe I overly considered the > extensibility of it. OK, Let me rework this patch to remove argsz from > these two ioctls. > > What about the existing ioctls for this driver, they have argsz too. > shall I prepare another patch to remove them as well? I am hoping you actually have users for those ioctls in userspace today? If not, and no one is using them, then yes, please fix those too. thanks, greg k-h
