Hi Florian! thanks for your patch! On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > From: Abbott Liu <liuwenliang@xxxxxxxxxx> > > The purpose of this patch is to provide set_ttbr0/get_ttbr0 to > kasan_init function. The definitions of cp15 registers should be in > arch/arm/include/asm/cp15.h rather than arch/arm/include/asm/kvm_hyp.h, > so move them. > > Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> > Reported-by: Marc Zyngier <marc.zyngier@xxxxxxx> > Signed-off-by: Abbott Liu <liuwenliang@xxxxxxxxxx> > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > +#include <linux/stringify.h> What is this for? I think it can be dropped. This stuff adding a whole bunch of accessors: > +static inline void set_par(u64 val) > +{ > + if (IS_ENABLED(CONFIG_ARM_LPAE)) > + write_sysreg(val, PAR_64); > + else > + write_sysreg(val, PAR_32); > +} Can we put that in a separate patch since it is not adding any users, so this is a pure refactoring patch for the current code? Yours, Linus Walleij