On Tue, 21 May 2019 17:42:28 +0800 Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> wrote: > On 2019/5/15 3:21, Steven Rostedt wrote: > > On Sun, 12 May 2019 11:35:27 +0800 > > Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> wrote: > > > >> The default behavior of hardlockup depends on the config of > >> CONFIG_BOOTPARAM_HARDLOCKUP_PANIC. > >> > >> Fix the description of nmi_watchdog to make it clear. > >> > >> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> > >> Reviewed-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx> > >> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > > Perhaps it should have been: > > > > Suggested-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > > > > As the wording is what I suggested ;-) > > Sure, I should have done that. Just not familiar with which one is better. > > Not clear if I should send a v3 adding Suggested-by and Acked-by? Yep, it's fine to add both: Suggested-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> -- Steve > > Zhenzhong