Re: [PATCH 3/3] kheaders: Make it depend on sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 11 May 2019 08:02:03 +0200
Cc: "Joel Fernandes (Google)" <joel@xxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, atish patra <atishp04@xxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, Brendan Gregg <bgregg@xxxxxxxxxxx>, Brendan Gregg <brendan.d.gregg@xxxxxxxxx>, Daniel Colascione <dancol@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, duyuchao <yuchao.du@xxxxxxxxxx>, Guenter Roeck <groeck@xxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Karim Yaghmour <karim.yaghmour@xxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Cc: Android Kernel" <kernel-team@xxxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Manjo Raja Rao <linux@xxxxxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Michał Gregorczyk <michalgr@xxxxxx>, Michal Gregorczyk <michalgr@xxxxxxxx>, Mohammad Husain <russoue@xxxxxxxxx>, Olof Johansson <olof@xxxxxxxxx>, Qais Yousef <qais.yousef@xxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Srinivas Ramana <sramana@xxxxxxxxxxxxxx>, Tamir Carmeli <carmeli.tamir@xxxxxxxxx>, Yonghong Song <yhs@xxxxxx>
In-reply-to: <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
User-agent: Mutt/1.11.4 (2019-03-13)

On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <joel@xxxxxxxxxxxxxxxxx> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
> 
> 
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
> 
> 
> Why don't you squash this?

I agree, this belongs in patch 1/3.

Follow-Ups:
- Re: [PATCH 3/3] kheaders: Make it depend on sysfs
  - From: Joel Fernandes

References:
- [PATCH 0/3] kheaders fixes for -rc
  - From: Joel Fernandes (Google)
- [PATCH 3/3] kheaders: Make it depend on sysfs
  - From: Joel Fernandes (Google)
- Re: [PATCH 3/3] kheaders: Make it depend on sysfs
  - From: Masahiro Yamada

Prev by Date: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
Next by Date: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework
Previous by thread: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
Next by thread: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]