On Tue, Apr 16, 2019 at 11:05:33AM +0200, Gerd Hoffmann wrote: > Also drop the dstclip parameter sphinx has warned about (leftolver from > an earlier patch version). > > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> Assuming it all builds cleanly and all the links work and no warnings from sphinx: Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/drm_format_helper.c | 1 - > Documentation/gpu/drm-kms-helpers.rst | 6 ++++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm/drm_format_helper.c > index da388012df2a..a18da35145b7 100644 > --- a/drivers/gpu/drm/drm_format_helper.c > +++ b/drivers/gpu/drm/drm_format_helper.c > @@ -235,7 +235,6 @@ static void drm_fb_xrgb8888_to_rgb888_line(u8 *dbuf, u32 *sbuf, > * @vaddr: XRGB8888 source buffer > * @fb: DRM framebuffer > * @clip: Clip rectangle area to copy > - * @dstclip: Clip destination too. > * > * Drivers can use this function for RGB888 devices that don't natively > * support XRGB8888. > diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst > index 58b375e47615..14102ae035dc 100644 > --- a/Documentation/gpu/drm-kms-helpers.rst > +++ b/Documentation/gpu/drm-kms-helpers.rst > @@ -107,6 +107,12 @@ fbdev Helper Functions Reference > .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c > :export: > > +format Helper Functions Reference > +================================= > + > +.. kernel-doc:: drivers/gpu/drm/drm_format_helper.c > + :export: > + > Framebuffer CMA Helper Functions Reference > ========================================== > > -- > 2.18.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch