On Fri, Apr 12, 2019 at 8:10 PM Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > On Sat, Apr 13, 2019 at 11:58 AM Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > On Sat, Apr 13, 2019 at 10:53 AM Daniel Colascione <dancol@xxxxxxxxxx> wrote: > > > > > > On Fri, Apr 12, 2019 at 6:49 PM Masahiro Yamada > > > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > > > > > On Sat, Apr 13, 2019 at 3:02 AM Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote: > > > > > > > > > > > > > > > > +extern char kernel_headers_data; > > > > > > > +extern char kernel_headers_data_end; > > > > > > > + > > > > > > > +static ssize_t > > > > > > > +ikheaders_read_current(struct file *file, char __user *buf, > > > > > > > > > > > > Could you stretch this line ? > > > > > > It will still fit in 80-cols. > > > > > > > > > > > > (This is a coding style error in kernel/configs.c) > > > > > > > > > > It takes 87 cols if I expand, so I'll leave it as is. > > > > > > > > > > > > > > > > > Sorry if what I said was unclear. > > > > > > > > Since I just did not a good reason to put > > > > "static ssize_t" in the previous line, > > > > I meant like follows: > > > > > > > > > > > > [Before] > > > > static ssize_t > > > > ikheaders_read_current(struct file *file, char __user *buf, > > > > size_t len, loff_t *offset) > > > > > > > > > > > > > > > > [After] > > > > static ssize_t ikheaders_read_current(struct file *file, char __user *buf, > > > > size_t len, loff_t *offset) > > > > > > > > > > > > (takes 74-cols.) > > > > > > > > > > > > (I am sending this from Gmail, so I am not sure > > > > how it will look like from you...) > > > > > > > > > > > > Anyway, it is super-bikeshedding stuff. > > > > It is OK as-is. > > > > > > > > > > What about sorting the files for determinism? > > > > > > Do you mean the order of files in the tar archive? Yes. > > I think it is a good idea for reproducible build. > > > > > > > > It looks like the tar command supports --sort=name option, > > but I did not test it at all. > > > > > > > > Perhaps, the sorting policy could be affected by locale. > > We saw it for the 'find' command. > > > 'sort' command is affected by locale. It should be independent of locale if you set LC_ALL=C in the environment while running it.
