Re: [PATCH] docs: remove spaces from shell variable assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 21 Mar 2019 14:37:56 +1300
Tom Levy <tomlevy93@xxxxxxxxx> wrote:

> The instructions for generating patches are given as shell commands
> with variables as placeholders. They use the syntax "SRCTREE= linux",
> which is wrong for the Bourne shell family (it runs the command
> "linux" with the variable "SRCTREE" set to the empty string).
> 
> Remove the spaces to avoid confusion. This breaks the pretty alignment
> but helps new contributors who try to run the commands as written.
> 
> Signed-off-by: Tom Levy <tomlevy93@xxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>

Applied, thanks.  Though I agree with Jani that this advice is looking a
little dated in general...

jon



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux