On Wed, 20 Mar 2019, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: > Per Thomas' yet-to-be-merged "tip tree handbook"[1], Co-developed-by and > Signed-off-by must be paired together, i.e. the co-authors' SOB mustn't > be scattered willy-nilly, and the author's SOB must be the first SOB > *after* the last Co-developed-by/Signed-off-by pair. Provide an example > to eliminate any ambiguity. > > [1] http://lkml.kernel.org/r/20181107171149.165693799@xxxxxxxxxxxxx > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx> > Cc: Joe Perches <joe@xxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Niklas Cassel <niklas.cassel@xxxxxxxxxx> > Cc: Jonathan Corbet <corbet@xxxxxxx> > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > --- > Documentation/process/submitting-patches.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > index be7d1829c3af..f4b5c4850601 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > @@ -547,8 +547,13 @@ have been included in the discussion. > > A Co-developed-by: states that the patch was also created by another developer > along with the original author. This is useful at times when multiple people > -work on a single patch. Note, this person also needs to have a Signed-off-by: > -line in the patch as well. > +work on a single patch. Note, Co-developed-by: must be accompanied by a > +Signed-off-by: of the co-author(s). All Co-developed-by:/Signed-off-by: pairs > +must precede the Signed-off-by: of the original author. > + > + Co-developed-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx> > + Signed-off-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx> > + Signed-off-by: Original Author <original@xxxxxxxxxxxxxxxxxx> Seems to me this suggests Original Author is involved in the patch from start to finish, and then gives Random Co-Author credit as well. IME it's more common for the Original Author to write a patch, and Random Co-Author to take over, finishing the job. Chronologically in this case I'd put the sign-offs the other way round. BR, Jani. > > > 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: -- Jani Nikula, Intel Open Source Graphics Center
