On 3/6/19 3:37 PM, Daniel Colascione wrote: > > I just don't get the opposition to Joel's work. The rest of the thread > already goes into detail about the problems with pure-filesystem > solutions, and you and others are just totally ignoring those > well-thought-out rationales for the module approach and doing > inflooping on "lol just use a tarball". That's not productive. > > Look; here's the bottom line: without this work, doing certain kinds > of system tracing is a nightmare, and with this patch, it Just Works. > You're arguing that various tools should do a better job of keeping > the filesystem in sync with the kernel. Maybe you're right. But we > don't live in a world where they will, because if this coherence were > going to happen, it'd work already. But this work solves the problem: > by necessity, anything that changes a kernel image *must* update > modules coherently, whether the kernel image and module come from the > filesystem, network boot, some kind of SQL database, or carrier > pigeon. There's nothing wrong with work that very cheaply makes the > kernel self-describing (introspection is elegant) and that takes > advantage of *existing* kernel tooling infrastructure to transparently > do a new thing. > > You don't have to use this patch if you don't want to. Please stop > trying to block it. > No, that's not how this works. It is far worse to do something the wrong way than not doing it at all, when it affects the kernel-user space interactions. Experience -- and we have almost 30 years of it -- has shown that hacks of this nature become engrained and all of a sudden is "mandatory". At the *very least* it needs to comply with the zero-one-infinity rule rather than being yet another ad hoc hack. More fundamentally, we already have multiple ways to handle objects that need to go into the filesystem: they can be installed with (or as) modules, they can use the firmware interface, and so on. Saying "it can be a module" is worse than a copout: even if dynamically loaded -- and many setups lock out post-boot module loadings for security reasons -- there is nothing to cause it to unload. The bottom line is that in the end there is no difference between making this an archive of some sort and a module, except that to use the module you need privilege that you otherwise may not need. If your argument is that someone may not be providing the whole set of items provided by "make modules_install", what is there to say that they would include your specific module? Here are some better ways of implementation I can see: 1. Include an archive in "make modules_install". Most trivial; no kernel changes at all. 2. Generalize the initramfs code to be able to create a pre-populated tmpfs at any time, that can be populated from an archive provided by the firmware loading mechanism; like all firmware allows it to either be built in or fetched from the filesystem. This allows it to be built in to the kernel image if that becomes necessary; using tmpfs means that it can be pushed out to swap rather than permanently stored in kernel memory, and this filesystem can be unmounted freeing its memory. 3. Use a squashfs image instead of an archive. -hpa
