On Fri, 2019-01-04 at 23:10 +-0100, Federico Vaga wrote: +AD4 On Friday, January 4, 2019 10:08:33 PM CET Bart Van Assche wrote: +AD4 +AD4 In emacs 23.1 support for directory-local variables was added (see also +AD4 +AD4 https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg00000.html). +AD4 +AD4 Simplify the settings in coding-style.rst by using that feature. +AD4 +AD4 Additionally, do not inherit any settings from emacs' linux coding style +AD4 +AD4 to minimize dependencies on the version of emacs that is being used. +AD4 +AD4 +AD4 +AD4 I have verified with several large and nontrivial kernel source files +AD4 +AD4 that the new settings format code according to what checkpatch expects. +AD4 +AD4 +AD4 +AD4 Signed-off-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 +AD4 +AD4 Cc: Matthew Wilcox +ADw-willy+AEA-infradead.org+AD4 +AD4 +AD4 Cc: Geyslan G. Bem +ADw-geyslan+AEA-gmail.com+AD4 +AD4 +AD4 Cc: Tiago Natel de Moura +ADw-tiago4orion+AEA-gmail.com+AD4 +AD4 +AD4 Cc: Alison Chaiken +ADw-alison+AEA-she-devel.com+AD4 +AD4 +AD4 Cc: Joe Perches +ADw-joe+AEA-perches.com+AD4 +AD4 +AD4 Cc: Federico Vaga +ADw-federico.vaga+AEA-vaga.pv.it+AD4 +AD4 +AD4 Cc: Li Yang +ADw-leo+AEA-zh-kernel.org+AD4 +AD4 +AD4 --- +AD4 +AD4 Documentation/process/coding-style.rst +AHw 57 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---------- +AD4 +AD4 1 file changed, 37 insertions(+-), 20 deletions(-) +AD4 +AD4 +AD4 +AD4 Changes compared to v1: +AD4 +AD4 - Removed top-level .dir-locals.el file again and updated coding-style.rst +AD4 +AD4 instead. - Restored the humourous paragraph about emacs. +AD4 +AD4 - Left out Italian and Chinese translations. +AD4 +AD4 Since now there are only code changes, I think you can apply them on both +AD4 Italian and Chinese translations. Good point. +AD4 As a general comment, I personally think that it worth to mention the fact +AD4 that the user can take this code (actually part of it) and put it in a .dir- +AD4 locals.el file in the top-level directory. I'm not sure we should recommend this. Settings in +AH4-/.emacs are not affected by git clean -f -x but .dir-locals.el is removed by that command. Thanks, Bart.
