Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 04 Jan 2019 08:32:38 -0800
Bart Van Assche <bvanassche@xxxxxxx> wrote:

> > Isn't it better if we collect such configuration files into a dedicated 
> > directory (where exactly?) instead of putting them in the top-level one? Then, 
> > the developer has to copy/link the configuration file into the top-level 
> > directory.  
> 
> I don't think so. The reason we have the checkpatch script and the
> coding-style.rst document in the kernel tree is to promote coding style
> uniformity. Placing the .dir-locals.el at the top level serves the same
> purpose. Additionally, if the .dir-locals.el file is not at the top level
> many kernel developers will overlook it.

I think we have to be careful about silently configuring other developers'
tools.  We put checkpatch.pl in the kernel tree, but we don't add a git
hook for everybody to run it.  I'm totally in favor of adding this .el
file to the documentation (or samples) directory and pointing users to it;
I'm less thrilled about putting in a dotfile where emacs will just pick it
up.

jon



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux