On 12/26/18 at 11:24am, Dave Young wrote:
> > >> +
> > >> +KERNEL_IMAGE_SIZE
> > >> +=================
> > >> +The size of 'KERNEL_IMAGE_SIZE', currently unused.
> > >
> > > So remove?
> > >
> >
> > I'm not sure whether it should be removed, so i keep it.
>
> Just remove it. It was added by Baoquan for KASLR issues, later
> makedumpfile reverted the userspace part and added other implementation.
>
> In case old makedumpfile does not support new kernel, it has some kernel
> versions support list in code, thus no worry about the compatibility
> issue.
Ah, it is not unused actually, clone crash tool git:
$ git grep KERNEL_IMAGE_SIZE
x86_64.c: if ((string = pc->read_vmcoreinfo("NUMBER(KERNEL_IMAGE_SIZE)"))) {
So in the documentation, the use cases of crash tool should also be
covered.
Lianbo, it would be good to cc Dave and Kazu for these patches, could
you cc them in your next post?
>
> Thanks
> Dave
Thanks
Dave
