On Tue, Nov 06, 2018 at 07:49:11AM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > > The ABI seems entirely undocumented and rather lightly designed, which > > seems like something we should fix before this is merged. > > ABI is documented in arch/x86/include/uapi/asm/sgx.h that from which the > documentation is included to intel_sgx.rst. I'm not saying that there is > no space refine it but it is neither undocumented. > > > Also, for a feature as massive and complicated as this one, it seems > > irresponsible to not have a selftest. Is that not feasible for some reason? > > I do have the in-kernel launch enclave stuff backed up here: > > https://github.com/jsakkine-intel/sgx-le-host > https://github.com/jsakkine-intel/sgx-le > > This is about as simple as it gets without any type of run-time. Of course the enclave could be simplified considerably since now it has full code for EINITTOKEN generation, which is probably an overkill for a selftest. It could be simple as just enter and return to and from enclave or something in-between in terms of complexity. Even for the simplest enclave you need a signing tool (see sgxsign.c in my sgx-le repository), a custom linker script and a sophisticated makefile. /Jarkko
