On Mon, Nov 5, 2018 at 2:58 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Nov 5, 2018 at 4:31 AM Peng Hao <peng.hao2@xxxxxxxxxx> wrote: > > > > By default, when ACPI tables and FDT coexist for ARM64, > > current kernel takes precedence over FDT to get device information. > > Virt machine in qemu provides both FDT and ACPI table. Increases the > > way to get information through FDT. > > > +#include <linux/acpi.h> > > +#include <linux/init.h> > > #include <linux/kernel.h> > > #include <linux/module.h> > > -#include <linux/init.h> > > +#include <linux/of.h> > > +#include <linux/of_address.h> > > +#include <linux/platform_device.h> > > #include <linux/types.h> > > -#include <linux/acpi.h> > > Adding new headers in this change is okay, while shuffling them is > logically a separate change. Couple more remarks (regarding ping-pong style in this series): 1. The shuffling part should go after you remove init.h: no need to shuffle the stuff you eventually remove. 2. When you introduce global variable for base, put it directly to the place where it would be after your ifdef patch. -- With Best Regards, Andy Shevchenko
