From: Nadav Amit Sent: November 1, 2018 at 4:31:59 PM GMT > To: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Igor Stoppa <igor.stoppa@xxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Kernel Hardening <kernel-hardening@xxxxxxxxxxxxxxxxxx>, linux-integrity <linux-integrity@xxxxxxxxxxxxxxx>, linux-security-module <linux-security-module@xxxxxxxxxxxxxxx>, Igor Stoppa <igor.stoppa@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Laura Abbott <labbott@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, open list:DOCUMENTATION <linux-doc@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Subject: Re: [PATCH 10/17] prmem: documentation > > > From: Peter Zijlstra > Sent: October 31, 2018 at 9:08:35 AM GMT >> To: Nadav Amit <nadav.amit@xxxxxxxxx> >> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Igor Stoppa <igor.stoppa@xxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Kernel Hardening <kernel-hardening@xxxxxxxxxxxxxxxxxx>, linux-integrity <linux-integrity@xxxxxxxxxxxxxxx>, linux-security-module <linux-security-module@xxxxxxxxxxxxxxx>, Igor Stoppa <igor.stoppa@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Laura Abbott <labbott@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, open list:DOCUMENTATION <linux-doc@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> Subject: Re: [PATCH 10/17] prmem: documentation >> >> >> On Tue, Oct 30, 2018 at 04:18:39PM -0700, Nadav Amit wrote: >>>> Nadav, want to resubmit your series? IIRC the only thing wrong with it was >>>> that it was a big change and we wanted a simpler fix to backport. But >>>> that’s all done now, and I, at least, rather liked your code. :) >>> >>> I guess since it was based on your ideas… >>> >>> Anyhow, the only open issue that I have with v2 is Peter’s wish that I would >>> make kgdb use of poke_text() less disgusting. I still don’t know exactly >>> how to deal with it. >>> >>> Perhaps it (fixing kgdb) can be postponed? In that case I can just resend >>> v2. >> >> Oh man, I completely forgot about kgdb :/ >> >> Also, would it be possible to entirely remove that kmap fallback path? > > Let me see what I can do about it. My patches had several embarrassing bugs. I’m fixing and will resend later, hopefully today.