Hi, Please fix the spacing for the colon in the commit title. It should be formatted as: misc/pvpanic: convert to SPDX license tags On Thu, Nov 01, 2018 at 11:09:58PM +0800, Peng Hao wrote: > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx> Other than the commit title, this looks fine to me: Acked-by: Mark Rutland <mark.rutland@xxxxxxx> Mark. > --- > drivers/misc/pvpanic.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c > index 66534d4..0bcf1cd 100644 > --- a/drivers/misc/pvpanic.c > +++ b/drivers/misc/pvpanic.c > @@ -1,21 +1,9 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* > - * pvpanic.c - pvpanic Device Support > + * Pvpanic Device Support > * > * Copyright (C) 2013 Fujitsu. > * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > */ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > -- > 1.8.3.1 >
