Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lee Jones <lee.jones@xxxxxxxxxx>
Subject: Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD
From: Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx>
Date: Wed, 24 Oct 2018 09:39:51 -0700
Cc: Mark Rutland <mark.rutland@xxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, linux-aspeed@xxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Vernon Mauery <vernon.mauery@xxxxxxxxxxxxxxx>, Frederic Barrat <fbarrat@xxxxxxxxxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>, Jason M Biils <jason.m.bills@xxxxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, openbmc@xxxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, Kishon Vijay Abraham I <kishon@xxxxxx>, "Bryant G . Ly" <bryantly@xxxxxxxxxxxxxxxxxx>, Uwe Kleine-Konig <u.kleine-koenig@xxxxxxxxxxxxxx>, David Kershner <david.kershner@xxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, linux-hwmon@xxxxxxxxxxxxxxx, Jean Delvare <jdelvare@xxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Philippe Ombredanne <pombredanne@xxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sagar Dharia <sdharia@xxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Cyrille Pitchen <cyrille.pitchen@xxxxxxxxxx>, Andrew Jeffery <andrew@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, James Feist <james.feist@xxxxxxxxxxxxxxx>, Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20181024072540.GA4939@dell>
References: <20180918215124.14003-1-jae.hyun.yoo@linux.intel.com> <20180918215124.14003-8-jae.hyun.yoo@linux.intel.com> <20181024072540.GA4939@dell>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Hi Lee,

On 10/24/2018 12:25 AM, Lee Jones wrote:

On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:

+Required properties:
+- compatible : Should be "intel,peci-client".
+- reg        : Should contain address of a client CPU. Address range of CPU
+	       clients starts from 0x30 based on PECI specification.


Nit: "start"

Would be better worded:

"According to the PECI specification client addresses start from 0x30."


Yes, that would be better. Will fix it like you suggested.

Thanks for the review!

Jae

References:
- [PATCH v8 00/12] PECI device driver introduction
  - From: Jae Hyun Yoo
- [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD
  - From: Jae Hyun Yoo
- Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD
  - From: Lee Jones

Prev by Date: Re: [PATCH 10/17] prmem: documentation
Next by Date: Re: [GIT PULL] Documentation for 4.20 (or whatever it's called)
Previous by thread: Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD
Next by thread: [PATCH v8 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]