On Tue, Aug 28, 2018 at 04:01:25PM +0300, Claudiu Beznea wrote: > Add documentation for PWM push-pull mode. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 2 ++ > Documentation/pwm.txt | 16 ++++++++++++++++ > include/dt-bindings/pwm/pwm.h | 1 + > 3 files changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentation/devicetree/bindings/pwm/pwm.txt > index 7c8aaac43f92..6a60c0fca112 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm.txt > +++ b/Documentation/devicetree/bindings/pwm/pwm.txt > @@ -49,6 +49,8 @@ Optionally, the pwm-specifier can encode a number of flags (defined in > - PWM_MODE_COMPLEMENTARY: PWM complementary working mode (for PWM channels > with two outputs); if not specified, the default for PWM channel will be > used > +- PWM_MODE_PUSH_PULL: PWM push-pull working modes (for PWM channels with > +two outputs); if not specified the default for PWM channel will be used What if somebody has this in the DT: PWM_MODE_COMPLEMENTARY | PWM_MODE_PUSH_PULL which one takes precedence, or do we reject it? Wouldn't it be preferable to either move the modes into an extra field within the flags field, or perhaps even add another field? I guess since Rob's already acked this, that concern may be unfounded. Thierry
Attachment:
signature.asc
Description: PGP signature
