On Thu 2018-10-11 10:42:47, Geert Uytterhoeven wrote: > - Make the ptr argument const, to avoid adding casts in future > callers, > - Move the function and its dependencies up, so it can be called from > special pointer type formatting routines. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> I have pushed the changes into printk.git, branch for-4.20-vsprintf-hash-fixes. Note that I have split it into two separate commits. The first one adds the const modifier. The second commit does a pure move of the code without any "hidden" changes. I forgot to ask for this when reviewing v1. You might see the result at https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/log/?h=for-4.20-vsprintf-hash-fixes Best Regards, Petr