Hello Guenter, On Wed, Sep 26, 2018 at 12:45:34PM -0700, Guenter Roeck wrote: > Hi Nicolin, > > On Wed, Sep 26, 2018 at 11:20:06AM -0700, Nicolin Chen wrote: > > On Wed, Sep 26, 2018 at 05:34:53AM -0700, Guenter Roeck wrote: > > > Hi Nicolin, > > > > > > On 09/25/2018 11:42 PM, Nicolin Chen wrote: > > > > The hwmon sysfs ABI supports powerX_input and powerX_crit. This > > > > can ease user space programs who care more about power in total > > > > than voltage or current individually. > > > > > > > > So this patch adds these two sysfs nodes for INA3221 driver. > > > > > Ah, sorry, we can't do that. The sysfs nodes are for chips providing power > > > registers, not for kernel drivers to provide calculations based on voltage > > > and current measurements. > > > > Hmm..I saw ina2xx.c and ltc4215.c are doing similar calculations... > > > > ina2xx.c doesn't; the chips supported by the driver do have a register > reporting the power (0x03). ltc4215.c was not reviewed by a hwmon > maintainer. I think I mentioned before that you can find anything you want > in the Linux kernel. That doesn't make it right. OK. In that case, I am dropping this change. Thanks Nicolin
