Re: [PATCH 2/3] tty_port: Fix function name and brief desc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 12, 2018 at 05:50:43PM +1000, Tobin C. Harding wrote:
> @@ -235,7 +235,7 @@ void tty_port_free_xmit_buf(struct tty_port *port)
>  EXPORT_SYMBOL(tty_port_free_xmit_buf);
>  
>  /**
> - * tty_port_destroy -- destroy inited port
> + * tty_port_destroy() - Destroy inited port.

Ok, using () for a function name, that's fine, but then you do:

>  /**
> - *	tty_port_tty_set	-	set the tty of a port
> - *	@port: tty port
> - *	@tty: the tty
> + * tty_port_tty_set - Set the tty of a port.

Oops, not here.  Consistency is the key.

thanks,

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux