2018-09-10 11:55 GMT+02:00 Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>: > > > On 10/09/18 09:43, Bartosz Golaszewski wrote: >>>> >>>> this series. Later patches are MUCH cleaner thanks to this removal and >>>> I believe it makes them easier for review. >>> >>> Am not sure about that, it definitely did not help me! >>> >> Why exactly? Aren't clean patches resulting from this removal easier >> to read then if they'd also have to take into account the burden of >> existing code that will be changes anyway later? I really don't see >> why you insist on removing this. > > > Here are few reasons: > > 1> TBH, This cleanup patch removes more than one feature from nvmem > subsystem. > Ex: it remove ability to add static cell from nvmem config, secondly it > removed ability to read/write cells directly using nvmem_cell_info. > About that: there are no users of nvmem_device_cell_read/write() currently and with the new API I'm not sure this is still needed. Are you alright with removing those two? Bart > 2> If you do changes as part of each patch, it will be much traceable on > what is changed exactly and will allow much better review, and understand > the reasoning. > > Having a clean start and writing code on top of it is alway nice, but we > will definitely miss things in review in this particular instance. > > > thanks, > srini > >> >> Best regards, >> Bart >> >
