Hi Kenneth, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kenneth-Lee/A-General-Accelerator-Framework-WarpDrive/20180903-162733 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago All warnings (new ones prefixed by >>): drivers/vfio/sdmdev/vfio_sdmdev.c: In function 'vfio_sdmdev_mdev_remove': >> drivers/vfio/sdmdev/vfio_sdmdev.c:178:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (sdmdev->ops->put_queue); ^~ drivers/vfio/sdmdev/vfio_sdmdev.c:179:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' sdmdev->ops->put_queue(q); ^~~~~~ # https://github.com/0day-ci/linux/commit/1e47d5e608652b4a2c813dbeaf5aa6811f6ceaf7 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 1e47d5e608652b4a2c813dbeaf5aa6811f6ceaf7 vim +/if +178 drivers/vfio/sdmdev/vfio_sdmdev.c 1e47d5e6 Kenneth Lee 2018-09-03 168 1e47d5e6 Kenneth Lee 2018-09-03 169 static int vfio_sdmdev_mdev_remove(struct mdev_device *mdev) 1e47d5e6 Kenneth Lee 2018-09-03 170 { 1e47d5e6 Kenneth Lee 2018-09-03 171 struct vfio_sdmdev_queue *q = 1e47d5e6 Kenneth Lee 2018-09-03 172 (struct vfio_sdmdev_queue *)mdev_get_drvdata(mdev); 1e47d5e6 Kenneth Lee 2018-09-03 173 struct vfio_sdmdev *sdmdev = q->sdmdev; 1e47d5e6 Kenneth Lee 2018-09-03 174 struct device *pdev = mdev_parent_dev(mdev); 1e47d5e6 Kenneth Lee 2018-09-03 175 1e47d5e6 Kenneth Lee 2018-09-03 176 put_device(pdev); 1e47d5e6 Kenneth Lee 2018-09-03 177 1e47d5e6 Kenneth Lee 2018-09-03 @178 if (sdmdev->ops->put_queue); 1e47d5e6 Kenneth Lee 2018-09-03 179 sdmdev->ops->put_queue(q); 1e47d5e6 Kenneth Lee 2018-09-03 180 1e47d5e6 Kenneth Lee 2018-09-03 181 return 0; 1e47d5e6 Kenneth Lee 2018-09-03 182 } 1e47d5e6 Kenneth Lee 2018-09-03 183 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
