Re: [PATCH v5 08/11] pci-epf-test/pci_endpoint_test: Add MSI-X support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on v4.18-rc1 next-20180620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gustavo-Pimentel/Add-MSI-X-support-on-pcitest-tool/20180621-042813
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-randconfig-x000-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Gustavo-Pimentel/Add-MSI-X-support-on-pcitest-tool/20180621-042813 HEAD 049a341869c0b8bb5160581848bcbd6d077829e0 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers//misc/pci_endpoint_test.c: In function 'pci_endpoint_test_ioctl':
>> drivers//misc/pci_endpoint_test.c:462:7: error: 'PCITEST_MSIX' undeclared (first use in this function); did you mean 'PCITEST_MSI'?
     case PCITEST_MSIX:
          ^~~~~~~~~~~~
          PCITEST_MSI
   drivers//misc/pci_endpoint_test.c:462:7: note: each undeclared identifier is reported only once for each function it appears in

vim +462 drivers//misc/pci_endpoint_test.c

   442	
   443	static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd,
   444					    unsigned long arg)
   445	{
   446		int ret = -EINVAL;
   447		enum pci_barno bar;
   448		struct pci_endpoint_test *test = to_endpoint_test(file->private_data);
   449	
   450		mutex_lock(&test->mutex);
   451		switch (cmd) {
   452		case PCITEST_BAR:
   453			bar = arg;
   454			if (bar < 0 || bar > 5)
   455				goto ret;
   456			ret = pci_endpoint_test_bar(test, bar);
   457			break;
   458		case PCITEST_LEGACY_IRQ:
   459			ret = pci_endpoint_test_legacy_irq(test);
   460			break;
   461		case PCITEST_MSI:
 > 462		case PCITEST_MSIX:
   463			ret = pci_endpoint_test_msi_irq(test, arg, cmd == PCITEST_MSIX);
   464			break;
   465		case PCITEST_WRITE:
   466			ret = pci_endpoint_test_write(test, arg);
   467			break;
   468		case PCITEST_READ:
   469			ret = pci_endpoint_test_read(test, arg);
   470			break;
   471		case PCITEST_COPY:
   472			ret = pci_endpoint_test_copy(test, arg);
   473			break;
   474		}
   475	
   476	ret:
   477		mutex_unlock(&test->mutex);
   478		return ret;
   479	}
   480	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux