I like this series overall, thanks! No objections from me. One thing I noted, though: On Fri, Apr 27, 2018 at 2:00 PM, Waiman Long <longman@xxxxxxxxxx> wrote: > if (param->min && *param->min > val) { > if (clamp) { > val = *param->min; > + clamped = true; > } else { > return -EINVAL; > } This appears as a common bit of logic in many places in the series. It seems like it'd make sense to make this a helper of some kind? -Kees -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html