Hi Boris, On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote: > Document the Cadence I3C gpio expander bindings. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-cdns-i3c.txt > +- #interrupt-cells : Should be 2. The first cell is the GPIO number. > + The second cell bits[3:0] is used to specify trigger type and level flags: > + 1 = low-to-high edge triggered. > + 2 = high-to-low edge triggered. > + 3 = triggered on both edges. > + 4 = active high level-sensitive. > + 8 = active low level-sensitive. These are identical to the values in <dt-bindings/interrupt-controller/irq.h>. Perhaps you can refer to those definitions? I don't think we want to see the hardcoded numbers in DTS files. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html