On 11/06/2017, 11:51 AM, Ricardo Ribalda Delgado wrote:
> The sample code does not initialize to zero a local variable and then it
> uses the uninitialized code.
>
> Fix in case someone copy/paste the sample code.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> ---
> Documentation/serial/serial-rs485.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/serial/serial-rs485.txt b/Documentation/serial/serial-rs485.txt
> index 389fcd4759e9..2bbae93bf279 100644
> --- a/Documentation/serial/serial-rs485.txt
> +++ b/Documentation/serial/serial-rs485.txt
> @@ -54,7 +54,7 @@
> /* Error handling. See errno. */
> }
>
> - struct serial_rs485 rs485conf;
> + struct serial_rs485 rs485conf = {};
I think that TIOCGRS485 is missing here instead. Ccing the author of the
text.
Does it break classifying potatoes :)?
> /* Enable RS485 mode: */
> rs485conf.flags |= SER_RS485_ENABLED;
>
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
